Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add skolemization support for ntriples, nquads, hextuples and json-ld support at parse time #2816

Merged
merged 13 commits into from
Jul 28, 2024
Merged

Add skolemization support for ntriples, nquads, hextuples and json-ld support at parse time #2816

merged 13 commits into from
Jul 28, 2024

Conversation

edmondchuc
Copy link
Contributor

@edmondchuc edmondchuc commented Jul 2, 2024 •
edited
Loading

Summary of changes

Add support for loading blank nodes as skolem IRIs at parse time for the following RDF formats:

  • ntriples
  • nquads
  • hext
  • json-ld

Fixes: #2736

Note that this relies on the recent changes made to hextuples' support for anonymous graph names. See #2815.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • If the change adds new features or changes the RDFLib public API:
    • Created an issue to discuss the change and get in-principle agreement.
    • Considered adding an example in ./examples.
  • If the change has a potential impact on users of this project:
    • Added or updated tests that fail without the change.
    • Updated relevant documentation to avoid inaccuracies.
    • Considered adding additional documentation.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@coveralls
Copy link

Coverage Status

coverage: 91.031% (+0.001%) from 91.03%
when pulling 93c930e on edmond/skolem-parsers
into 0ecc400 on main.

@coveralls
Copy link

coveralls commented Jul 15, 2024 •
edited
Loading

Coverage Status

coverage: 91.063%. first build
when pulling 2043162 on edmond/skolem-parsers
into 0853467 on main.

@nicholascar nicholascar added the enhancement New feature or request label Jul 24, 2024
@nicholascar nicholascar changed the title feat: add skolemization support for ntriples, nquads, hextuples and json-ld support at parse time Add skolemization support for ntriples, nquads, hextuples and json-ld support at parse time Jul 24, 2024
@ashleysommer
Copy link
Contributor

This is passing, but I still haven't done a full review of it yet. I'll hopefully get to it this weekend.

@nicholascar
Copy link
Member

pre-commit.ci autofix

@nicholascar nicholascar merged commit 2053ecd into main Jul 28, 2024
22 checks passed
@nicholascar nicholascar deleted the edmond/skolem-parsers branch July 28, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholascar nicholascar nicholascar approved these changes

@ashleysommer ashleysommer Awaiting requested review from ashleysommer

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optional skolemize blank nodes on parse
4 participants
@edmondchuc @coveralls @ashleysommer @nicholascar